Open
Conversation
kenoi1
force-pushed
the
work/dereklin/workflows
branch
from
0bbc354 to
e7a2c68
Compare
kenoi1
changed the title
Collaborator
|
The linter looks good! For the build_test workflow, does it actually test anything currently? I see that it calls docker compose build only, what is your intended way for a node to be tested? For the monorepo, I believe it calls the script inside https://github.com/WATonomous/wato_monorepo/tree/main/.github/templates/test . Either way, could you add some trivial tests to gym_vis and check if it runs? |
…_toolbox, added : jstest-gtk, added : display passthrough for (workso on linux), input passthough for devies into the container (gamepads can be used in the container now)
Author
|
should be ready for review again! let me know if there's anything else to edit, or if I should squash the branch now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some pipelines that run on PRs against main to address issues #23 and #18. I also ran the auto formatter so it passes these tests.
See
(Tutorial) Micro Autonomy Testing Pipelines.mdin the changes for more details.auto-lintlabel to your PR to run the formatter